GitHub Branch Source Plugin & Github pull requests status

Answered

Giorgos Papadopoulos

• September 11, 2019 10:05

I'm using the plugin to set the status of my github PRs.
A failed build sets the github status of that PR to Failure (red x icon) and a successful build sets the status to Success (green check icon)

Problem is with the unstable builds from Jenkins which set the status to Success on github.

I'm using version 2.176.2 and its current setup has 3 states: failed (red ball), unstable (yellow ball) and success (green ball)

Is it possible to change this behaviour and the unstable builds to set the github status to Failure?

0

• 

  Raymond Kivisto

  • September 11, 2019 14:12
  • Edited

  Hi Giorgos,

  I was checking the code and it seems like the code is intending to set the GitHub status to `FAILURE` when the build is unstable:

  https://github.com/jenkinsci/github-branch-source-plugin/blob/ee1db1cd7a00544a5d527a1b1694f54f0866099b/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubNotificationContext.java#L221

  Which version of the github-branch-source-plugin do you have installed, and is the GitHub repo you are using a public repo?

  0
• 

  Giorgos Papadopoulos

  • September 11, 2019 14:31

  Hi Ray,

  thank you for your quick reply.
  
  We are using Jenkins 2.176.2 and github-branch-source-plugin 2.4.2
  The repo is not public, it is a private organisation repo (enterprise github)

  0
• 

  Denys Digtiar

  • September 17, 2019 07:04

  Your version also seems to map the UNSTABLE to the FAILURE status.

  https://github.com/jenkinsci/github-branch-source-plugin/blob/github-branch-source-2.4.2/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubNotificationContext.java#L215-L231

  I tried to quickly reproduce on 2.5.5 and couldn't. Both FAILURE and UNSTABLE results in the red cross on Github PR. 

  0

Please sign in to leave a comment.